if statments

Also note that use of "double" for money will result in inaccuracies. For learning purposes, double is good but you must expect inaccuracies in the monetary calculations. For monetary data, use Decimal. There are many things to learn and this is one you can learn about when you are ready to but you can continue using double for now.

The Main, Members and Nonmembers are functions, not classes. Functions are also called methods. There is only one class; it is called "Program". That class has the Main, Members and Nonmembers methods. You can create a separate class for holidays and put the data and methods for holidays in the holidays class.

One thing that is likely confusing is that a holiday can be the data describing the possible holidays for example the type of tent and such or it can be a specific holiday in terms of the type of holiday that was chosen and the number of days and such. All this is a good beginning at understanding Object Oriented Programming (OOP).

Ok.. I think I uderstand where your going with this... Im starting to understand the while and do statements now. In my program you basicly broke it up in to three classes. (main) (Members) and (nomembers) and I agree this is best as programmers can see strait away what the program is supposed to do.  I think what your trying to say is I can do this for each of the choices  to create as such a sub class with in a class. Is this nesting? Do you know I'm learning more from you than I learn at uni. Am I on the right track?

A lot of your code is very similar. Most or all the funtions that calculate the cost of a holiday are very similar. You can create functions to do each of the calcculations.

One advantage of separating high-level from low-level is it makes your top-level logic easier to read. Experienced programmers try to separate the high-level logic from lower-level logic. You original program has all levels combined together. It is not as much of a problem in your current program but more complex requirements can quickly make the program much more cmplicated.

Another advantage of is that it is easier to combiine functions. You can pass parameters to functions thereby using a function multiple times each for a slightly different purpose.

You could create a class that represents each accomodation such as tent or room. The class would have the accomodation name and the cost. You could create an array of the accomodation objects then pass an instance of the array to a function that lists the accomodations and asks for a selection then calculates the holiday based on the selections and such. I understand that a lot of that is too advanced for you, but I hope it helps to have this to think about.

Yeah ok, your version is best. I can see where your going with this. Im going to write some examples so I completely understand it.

From what I can see you have broken the code into two with nonemembers first followed by members.

Tell you the truth I did wonder if this can be done but didn't understand how untill now. Sam you have been great and I very much appreciate all the tution you have given me, I hope I can call on you again if I get stuck.

I've been reading that there is a massive debate about goto's, lol Thaks for the attached file I will take a look at it now and get back to you...

Hope I don't fail my assignmnet for using code I haven't been tought by my tutor yet, tell you the truth Sam I don't think my tutor is teaching me fast enough. I understand that others in my class learn at different rates but I need a C# mental overload as I'm very interested in this subject.

I welcome all input, and as you are a very experienced programmer... if you tell me I'm doing something wrong and advice me to make changes I will do this.

Have a good day, going to take a look at your version now.

Look at the attached; I think it does the same thing that your latest version does. I tried to not get too advanced for you. There are of course many more improvements that can be made.


Note that my version does work a little differently. My version assumes that the same person is using it while it is executing. So my version asks if the person is a member and it does not ask again if the person is a membefr; it assumes that if the person is a member the first time, they are still a member and if not a member then they are not a member no matter how many holidays they ask for. Both of our versions ask for the person's name each time it calculates a holiday. If you need to allow the program to do calculations for more than one person (in other words, not the same person every time) during execution, then the program needs to be modified a little.


There are many more improvements, but I am not sure how much you would understand. It would take time to re-write the program some more but if I did that then I would also need to spend time explaining what I did. So for now at least, have a look at what I did.

Oh, and yes the goto is valid in the language but most programmers would have a strong negative reaction to it's use. There is absolutely no good book about the language that would recommend use of goto. Any book that teaches use of goto as being good would be considered by most programmers to be a bad book. Gotos were used a lot half a century ago but for the past quarter of a century they have been considered to be bad.

No my tutor has's taught me this, he hasn't taught me much. I'm taking all this is a bit to quick for them I think thats why Im asking experienced programmers like yourselves questions.

Like I said I've only been doing this 2 weeks so I'm the nood of all noobs.
The goto statment is valid in C# see here http://msdn.microsoft.com/en-us/library/13940fs2.aspx

If you know a better way then please tell me how and I'll make the changes to the code.

Again thanks for your imput.

What? Goto? I did not know that that is in C#. You must know how to program without goto or else you will be ridiculed and harrased everywhere you go until you remove the existance of the cancer from your system. If your instructor taught you to use goto then that instructor is among the worst of all instructors and there has definitely been many complaints in the past about him or her.

Ok guys I decided to re-write all of it and now it works, could everyone take a look at my code and tell me if its ok.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace ConsoleApplication1
{
    class Program
    {
        static void Main(string[] args)
        {
        Start:
            string StrChoice = "";
            string StrName;



            string StrNightsStay;
            double DblNightsStay;



           




            Console.Clear();
            Console.Write("\nWelcome to your holiday planner\n");
            Console.Write("Member's get 25% of their holidays this year, are you a member Y/N?:");
            StrChoice = Console.ReadLine();
            if (StrChoice == "Y")
            {
                goto Members;
            }
            else
                if (StrChoice == "N")
                {
                    goto NoneMembers;
                }

        Members:

            double DblMA;
            double DblMB;
            double DblMC;
            double DblMD;

            double DblM2PersonTent = 2.25;
            double DblMOtherTents = 3.75;
            double DblMCaravan = 7.50;
            double DblMChalet = 11.25;

           



            Console.Clear();
            Console.Write("What is your full name:");
            StrName = Console.ReadLine();
            Console.Clear();
            Console.Write("Welcome back {0}", StrName);
            Console.Write("\nHere is this years holiday prices, your 25% discount will be detucted \non your final quote.\n");
            Console.Write("\nA 2 person tent costs       £3.00 per night\n");
            Console.Write("B Other tents costs         £5.00 per night\n");
            Console.Write("C Caravan costs             £10.00 per night\n");
            Console.Write("D Chalet costs              £15.00 per night\n");
            Console.Write("\nPlease enter you holiday type:");
            StrChoice = Console.ReadLine();

            if (StrChoice == "A")
            {
                Console.Write("\nHow many nights would you like to stay with us:");
                StrNightsStay = Console.ReadLine();
                DblNightsStay = double.Parse(StrNightsStay);
                DblMA = DblM2PersonTent * DblNightsStay;
                Console.Write(" \nYour cost of this holiday is:{0}", DblMA);
                Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                StrChoice = Console.ReadLine();
                if (StrChoice == "Y")
                {
                    goto Start;
                }
                else
                {
                   
                }

            }

            else
                if (StrChoice == "B")
            {
                Console.Write("\nHow many nights would you like to stay with us:\n");
                StrNightsStay = Console.ReadLine();
                DblNightsStay = double.Parse(StrNightsStay);
                DblMB = DblMOtherTents * DblNightsStay;
                Console.Write(" \nYour cost of this holiday is:{0}", DblMB);
                Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                StrChoice = Console.ReadLine();
   
                   
                if (StrChoice == "Y")
                {
                    goto Start;
                }
                else
                {
                   
                }
            }

            else
                if (StrChoice == "C")
            {
                Console.Write("\nHow many nights would you like to stay with us:\n");
                StrNightsStay = Console.ReadLine();
                DblNightsStay = double.Parse(StrNightsStay);
                DblMC = DblMCaravan * DblNightsStay;
                Console.Write(" \nYour cost of this holiday is:{0}", DblMC);
                Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                StrChoice = Console.ReadLine();
                if (StrChoice == "Y")
                {
                    goto Start;
                }
                else
                {
                   
                }
            }

                else
                    if (StrChoice == "D")
            {
                Console.Write("How many nights would you like to stay with us:");
                StrNightsStay = Console.ReadLine();
                DblNightsStay = double.Parse(StrNightsStay);
                DblMD = DblMChalet * DblNightsStay;
                Console.Write(" \nYour cost of this holiday is:{0}", DblMD);
                Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                        StrChoice = Console.ReadLine();
                if (StrChoice == "Y")
                {
                    goto Start;
                }
                else
                {
                   
                }
            }
                   
           
                else
                    if (StrChoice == "N")
    {
        goto NoneMembers;
    }


            NoneMembers:

            double DblA;
            double DblB;
            double DblC;
            double DblD;

            double Dbl2PersonTent = 3.00;
            double DblOtherTents = 5.00;
            double DblCaravan = 10.00;
            double DblChalet = 15.00;





            Console.Clear();
            Console.Write("What is your full name:");
            StrName = Console.ReadLine();
            Console.Clear();
            Console.Write("Welcome back {0}", StrName);
            Console.Write("\nHere is this years holiday prices, if you was a member you would of        saved 25%\non your holiday.\n");
            Console.Write("\nA 2 person tent costs       £3.00 per night\n");
            Console.Write("B Other tents costs         £5.00 per night\n");
            Console.Write("C Caravan costs             £10.00 per night\n");
            Console.Write("D Chalet costs              £15.00 per night\n");
            Console.Write("\nPlease enter you holiday type:");
            StrChoice = Console.ReadLine();

            if (StrChoice == "A")
            {
                Console.Write("\nHow many nights would you like to stay with us:");
                StrNightsStay = Console.ReadLine();
                DblNightsStay = double.Parse(StrNightsStay);
                DblA = Dbl2PersonTent * DblNightsStay;
                Console.Write(" \nYour cost of this holiday is:{0}", DblA);
                Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                StrChoice = Console.ReadLine();
                if (StrChoice == "Y")
                {
                    goto Start;
                }
                else
                {

                }

            }

            else
                if (StrChoice == "B")
                {
                    Console.Write("\nHow many nights would you like to stay with us:\n");
                    StrNightsStay = Console.ReadLine();
                    DblNightsStay = double.Parse(StrNightsStay);
                    DblB = DblOtherTents * DblNightsStay;
                    Console.Write(" \nYour cost of this holiday is:{0}", DblB);
                    Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                    StrChoice = Console.ReadLine();


                    if (StrChoice == "Y")
                    {
                        goto Start;
                    }
                    else
                    {

                    }
                }

                else
                    if (StrChoice == "C")
                    {
                        Console.Write("\nHow many nights would you like to stay with us:\n");
                        StrNightsStay = Console.ReadLine();
                        DblNightsStay = double.Parse(StrNightsStay);
                        DblC = DblCaravan * DblNightsStay;
                        Console.Write(" \nYour cost of this holiday is:{0}", DblC);
                        Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                        StrChoice = Console.ReadLine();
                        if (StrChoice == "Y")
                        {
                            goto Start;
                        }
                        else
                        {

                        }
                    }

                    else
                        if (StrChoice == "D")
                        {
                            Console.Write("How many nights would you like to stay with us:");
                            StrNightsStay = Console.ReadLine();
                            DblNightsStay = double.Parse(StrNightsStay);
                            DblD = DblChalet * DblNightsStay;
                            Console.Write(" \nYour cost of this holiday is:{0}", DblD);
                            Console.Write(" \nWould you like to try a different choice of holiday Y/N:");
                            StrChoice = Console.ReadLine();
                            if (StrChoice == "Y")
                            {
                                goto Start;
                            }
                            else
                            {

                            }
                        }


                        else
                            if (StrChoice == "N")
                            {
                               
                            }
       

        }
        }
}


   

Thanks for the input guys, hope soon I get as good as you two. I am new to all this but I am starting to see the dynamics to it all.

Thanks for you help.

As Jean Paul says, use ReadKey if you need to get a single character such as "Y". Use ReadLine if you need more than a character, such as for reading the nights to stay. When you use ReadLine, the input must be ended using the enter key. I see you are using Read and that might work; I am not sure.

I suggest making functions for doing things so that your main function is smaller. If you don't understand what I mean then ignore it.

One big problem is that you are writing "Your Cost for this holiday is £" but you are not writing the cost. You need to refer to your notes from class or something such as that to know how to write the cost; it will be something such as:

Console.WriteLine("Your Cost for this holiday is £{0}", DblD);

You say you get a "blanks screen". I suspect that the screen is not totally blank; I suspectg that you are getting something but just not everything. If so then you need to learn to be accurate in your problem description. There is no evidence that the program won't show something at least so people have not been able to help you with that. If instead you are getting some output but not all and if you had said that that is what is happening then you would have gotten more help sooner.

That was a cool amout of code.  Although I could not understand the business logic,
I found the following error:
The Console.Read() goes for an infinite loop reading char.
Instead of that use
char y = (char)Console.ReadKey().KeyChar;
for all the Read()
Whenever you are using ReadLine() use enter charcter to complete the reading.
Happy Coding Dude!