Problem in update

Question

try
{
OleDbConnection con = new OleDbConnection(ConnectionString);
con.Open();
string s1 = dtp_date.Value.ToShortDateString();
OleDbCommand cmd = new OleDbCommand("update dbo_Diesel_Master set Petrol_pump_name='" + txt_Petrl_pump_name.Text + "',Vehicle_No='" + cmb_VehicleNo.Text + "',Fuel='" + txt_Fuel.Text + "',Rate='" + txt_rate.Text + "',Date='" + s1 + "',Challan_No='" + txt_challan_no.Text + "',Amount='" + txt_amt.Text + "' where Petrol_pump_name='" + DGV_Diesel.SelectedRows[0].Cells[0].Value + "'", con);
cmd.ExecuteNonQuery();
cmd = new OleDbCommand("select * from dbo_Diesel_Master", con);
dr = cmd.ExecuteReader();
DataTable dt = new DataTable();
dt.Load(dr);
DGV_Diesel.DataSource = dt;
MessageBox.Show("updated successfully.....");
con.Close();
}
catch (Exception ex)
{
MessageBox.Show("please select a record for delete..");
}

Vijay Yadav · Accepted Answer

Hi Snehal,
Debug the code and copy & paste into the sql query analyzer, to make sure whether that query is geting executed properly in sql.

Krishna Garad · Answer

paste the error here then we can help you. Many reason can be sql injection also or as arti says closing of connection before executing nonquery. So pleas paste the detailed error here.

Aarti · Answer

HI,
call cmd.ExecuteNonQuery(); before con.close(); in try block

Snehal Bobde · Answer

after execution of the statement
cmd.ExecuteNonQuery();
it go to catch.
It will not execute the remaining code.
cmd = new OleDbCommand("select * from dbo_Diesel_Master", con);
dr = cmd.ExecuteReader();
DataTable dt = new DataTable();
dt.Load(dr);
DGV_Diesel.DataSource = dt;
MessageBox.Show("updated successfully.....");
con.Close();

Krishna Garad · Answer

what is the exact problem with your code.